n_bins parameter to Evaluator() to control lift curve computation#56
n_bins parameter to Evaluator() to control lift curve computation#56JanBenisek merged 7 commits intodevelopfrom
Conversation
…val lift curve is computed
JanBenisek
left a comment
There was a problem hiding this comment.
Looks good, but please could you add one unit test to see if the function _compute_lift_per_bin() really returns as many bins as asked? Might be straightforward, but let's try having a good test coverage, thanks!
Series of small commits but the test is there. Strange it gives conflicts - all new code is an addition, not a modification. You can resolve using the web editor and merge to develop. |
|
@sborms thanks, all good, conflicts resolved (just some small annoyance). |
sandervh14
left a comment
There was a problem hiding this comment.
OK, I went over the code. No comments.
fixes #35
n_binsto theEvaluator()class, to allow flexibility in terms of choosing the number of lift curve bins to compute and hence plot